BillyClark

This does happen a lot, but have you ever had the opposite happen? Where you go into some of your older code, and not only is it nice to read, but you had anticipated that you’d have to make this change later, and so the design makes the change easy?

That’s happened to me a few times and all I can say is that it takes days for my self-satisfaction to wane.

It’s a bit of a change of mindset to begin thinking that you can’t trust a PR even a little.

It has never occurred to me that other people trust PRs, even a little. I mean, that they might think about it in those terms.

This explains a lot to me.

Why does it take me longer to review code than other people? They trust the person who wrote it, but I don’t.

Why is it that when my coworkers think a person is untrustworthy, that they always end up begging me to do all of that person’s reviews. It’s because I’m not bothered by that. I already treat everybody as untrustworthy.

I’ve never understood how other people think when they do reviews, I guess.

Forgetting AI for a moment, I am always shocked when I am reviewing a coworker’s code and it’s obvious that they themselves didn’t review it.

Like, they sent me a PR that has a whole shitload of other crap in it. Why should I look at it when you haven’t looked at it? If you don’t review your own review requests, you’re a failure of a programmer human.

And I would be a failure if I approved such a request.

Getting back to the post, where is all of the review? The coworker should have reviewed the AI shit, whether it was code or documentation. The person who approved the PR should have reviewed it, as well.

Every business with more than one programmer should have at least two levels of safeguards against this exact thing happening. More if you include different types of test suites.

This post describes a fundamentally broken business, regardless of the AI angle, and so it’s good if everything is broken. With such a lack of discipline and principles, I say let the business fail.