Martin

I would go with a trunk based approach. In other words no other long lived branches other than main. Push for review often and merge to main as soon as it’s approved.

If you don’t see a need for a more complex branch strategy, you probably don’t need it. Branches are always an increased risk for conflicts and can be a pain to resolve.

I have a great boss that knows that whatever I decide to do is probably the right priority. As long as our users are happy she is happy.

Is it quicker to fix it then to get the issue triaged? Just fix it and move on.

They disappeared for a reason. It was a crappy gimmick.

South of Sweden

I’ve been using Linux professionally for 15 years. It’s been Debian or Ubuntu almost everywhere I have been. Although that might be regional.

If you know how the code does something, you also know what it does.

You are absolutely right. It was inline comments I had in mind.

Absolutely, although I see that as part of why

Why is there a horrible hack here? Because stupid reason…

Comments should explain “why”, the code already explains “what”.

You are right, I didn’t think of MBR.

It was possible for Ubuntu once upon a time

When a colleague generated a dia graph for each git object that got created when he made a few commits. Understanding the underlying data model was a real aha moment. 13 years later and I’m still grateful for his “mini git course”.

We have well established ways to deal with secrets. Also, everyone is responsible enough to not self approve changes where they do things they are uncertain of.

We very seldom resort to self approvals. Everyone in the team see code reviews as important. But also that progress trumps code review.

Who said anything about only requiring 1 reviewer? And no, I did not drop an /s. You should try working for a healthy team where everyone takes collective responsibility and where the teams progress is more important than any one person’s progress.

We decided that everyone in the team is allowed to approve changes. If no one has reviewed your change within 24 hours you are allowed to approve it yourself. It will usually come up in the daily sync that a self approval is imminent, which usually leads to someone taking a look.

This comment was a better read than the linked article.

How does switching the codec help with downloading subtitles from the web?

Is using the Android TV app considered “using it wrong”? Because that doesn’t support downloading subtitles.