The post body:
[…] big refactoring project to replace the usage of double types with decimal types. Everything seemed to go well, at least until there was a network hiccup and the application couldn’t connect to the database. Let’s see if you can figure out what happened:
MessageBox.Show("Please decimal check the connection details. Also check firewall settings (port 1433) and network connectivity.");
What a clbuttic mistake.
I don’t actually get the joke with clbuttic
, though. 🤔
I can already see the 10,000 line PR touching 50 files and the sole review comment “👍”
A long time ago I worked on a project which had all the user-facing text strings in their own separate file (for ease of translation). I didn’t think much more of it at the time, but even if I was just rubber-stamping this PR then seeing that a code-only refactor was touching the strings file would raise an eyebrow.
That’s a good practice. Seems obvious now that you’ve mentioned it, actually, but I don’t think I’ve ever done it. Except maybe incidentally when building an i18n table.
“LGTM”