This post was brought to you by this PMD rule.
Transcription
Why do we have this stupid code analyzer rule enabled anyway? Nobody writes code like this…
After telling them the lore why it’s there:
You have seen such things before?
11 Times, as a matter of fact
It’s like saying
list.isEmpty()overlist.getLength() == 0is a picky optimisation.There’s a developer out there who coded this and they obviously don’t know what they’re doing. One day they’re gonna iterate all rows in the database to check if it’s empty. You have to flag these issues early and teach the newbies.